SBDevelopment
/
VehiclesPlusConverter
3
1
Fork 1
Code Issues 1 Pull Requests Releases 2 Activity

now it works in pre4. #2

Closed
JuliGame wants to merge 1 commits from JuliGame/VehiclesPlusConverter:master into master
pull from: JuliGame/VehiclesPlusConverter:master
merge into: SBDevelopment:master
Conversation 1 Commits 1 Files Changed 1 +21 -11
JuliGame commented 2024-01-23 11:30:59 +00:00
First-time contributor
Copy Link

Made it work in pre4.
There are some hardcoded things that should be fixed in line 242.

Made it work in pre4. There are some hardcoded things that should be fixed in line 242.
JuliGame added 1 commit 2024-01-23 11:31:00 +00:00
SBDeveloper reviewed 2024-01-23 12:23:49 +00:00
src/main/java/tech/sbdevelopment/vehiclesplusconverter/handlers/Converter.java
@ -245,2 +250,4 @@
.gearbox(new Gearbox(true, 10))
.build();
// Idk why but it was detecting type as "car" and it should be "cars" to work
SBDeveloper commented 2024-01-23 12:23:44 +00:00
Owner
Copy Link

That's weird, will check that out before merging this PR.

That's weird, will check that out before merging this PR.
SBDeveloper commented 2024-01-23 21:18:45 +00:00
Owner
Copy Link

Thanks, I updated to the latest snapshot build based on this PR in 841f8c358f.

Thanks, I updated to the latest snapshot build based on this PR in 841f8c358fdc9f1ece3f9964adb6ba65a98d4ee8.
SBDeveloper closed this pull request 2024-01-23 21:18:46 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SBDevelopment/VehiclesPlusConverter#2
No description provided.
Delete Branch "JuliGame/VehiclesPlusConverter:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?