Rewrite of collision detection #78

Closed
opened 2021-03-08 13:41:15 +00:00 by stijnb1234 · 8 comments
stijnb1234 commented 2021-03-08 13:41:15 +00:00 (Migrated from github.com)

Describe the bug
Slab driving is at the moment very buggy.

To Reproduce
I tried the following combinations:

1:

driveOverSlabs: false
driveOverBlocks: true
vehicleDamage: false

This will cause a very bumpy car, that sometimes stops for slabs.

2:

driveOverSlabs: true
driveOverBlocks: true
vehicleDamage: false

This will cause slowdown issues when riding over slabs (half blocks).

3:

driveOverSlabs: false
driveOverBlocks: true
vehicleDamage: true

This will cause slowdown issues when riding over slabs (half blocks).

4:

driveOverSlabs: true
driveOverBlocks: true
vehicleDamage: true

Your vehicle will sometimes get destroyed when you are driving upward slabs.

Expected behavior
It should run smoothly without any slowdown issues.

Screenshots or Video Recordings

Server and Plugin Information

  • VehiclesPlus Version: 2.2.6-dev3
  • Pro or Lite? Pro
  • Server Platform and Version [eg: PaperSpigot 1.16.1 #135]: PaperSpigot 1.16.5 #470
  • Operating System (if applicable): Ubuntu 20.04

Additional context

**Describe the bug** Slab driving is at the moment very buggy. **To Reproduce** I tried the following combinations: ## 1: ```yml driveOverSlabs: false driveOverBlocks: true vehicleDamage: false ``` This will cause a very bumpy car, that sometimes stops for slabs. ## 2: ```yml driveOverSlabs: true driveOverBlocks: true vehicleDamage: false ``` This will cause slowdown issues when riding over slabs (half blocks). ## 3: ```yml driveOverSlabs: false driveOverBlocks: true vehicleDamage: true ``` This will cause slowdown issues when riding over slabs (half blocks). ## 4: ```yml driveOverSlabs: true driveOverBlocks: true vehicleDamage: true ``` Your vehicle will sometimes get destroyed when you are driving upward slabs. **Expected behavior** It should run smoothly without any slowdown issues. **Screenshots or Video Recordings** - **Server and Plugin Information** - VehiclesPlus Version: 2.2.6-dev3 - Pro or Lite? Pro - Server Platform and Version [eg: **PaperSpigot** 1.16.1 #135]: PaperSpigot 1.16.5 #470 - Operating System (if applicable): Ubuntu 20.04 **Additional context** -
stijnb1234 commented 2021-03-31 15:17:04 +00:00 (Migrated from github.com)

Slabdriving bugs is still a thing in the latest build (containing other fixes).

Slabdriving bugs is still a thing in the latest build (containing other fixes).
stijnb1234 commented 2021-04-15 17:52:49 +00:00 (Migrated from github.com)

Example

![Example](https://user-images.githubusercontent.com/27051051/114915648-1b5ca600-9e24-11eb-8277-c8e4fcf868ac.gif)
dylanbrands2006 commented 2021-04-15 17:57:23 +00:00 (Migrated from github.com)

Try placing the armorstand a little bit more up

Try placing the armorstand a little bit more up
ORGN-G commented 2021-06-08 15:02:30 +00:00 (Migrated from github.com)

I'm getting the same issue as the gif image.

・VehiclesPlus-Pro 2.3.0
・Spigot (2991-Spigot-018b9a0-f3f3094) on RHEL7.7
・Paper (git-Paper-753 (MC: 1.16.5)) on CentOS7.4
・openjdk version "11.0.11" 2021-04-20 LTS

I'm getting the same issue as the gif image. ・VehiclesPlus-Pro 2.3.0 ・Spigot (2991-Spigot-018b9a0-f3f3094) on RHEL7.7 ・Paper (git-Paper-753 (MC: 1.16.5)) on CentOS7.4 ・openjdk version "11.0.11" 2021-04-20 LTS
MelonHell commented 2022-06-03 15:58:52 +00:00 (Migrated from github.com)

I see this issue has been open for a very long time, maybe my advice will help in development.

Once for my server, I fixed this. The whole problem is the hitbox system and the vanilla gravity of the stands. To fix this, I used RayTrace in the hitboxes and replaced the gravity of the stands with a loop that tries to move the car down

I see this issue has been open for a very long time, maybe my advice will help in development. Once for my server, I fixed this. The whole problem is the hitbox system and the vanilla gravity of the stands. To fix this, I used RayTrace in the hitboxes and replaced the gravity of the stands with a loop that tries to move the car down
MelonHell commented 2022-06-03 17:10:50 +00:00 (Migrated from github.com)

I don't remember how the hitbox system works in your plugin. I would do this: there are points on the edges of the hitbox that check if they are in the air (in bukkit there is a function to check if the point touches the solid part of the block), the car moves until the point is in the block. if the car is stuck in the block - it is pushed out

I don't remember how the hitbox system works in your plugin. I would do this: there are points on the edges of the hitbox that check if they are in the air (in bukkit there is a function to check if the point touches the solid part of the block), the car moves until the point is in the block. if the car is stuck in the block - it is pushed out
Felleus commented 2022-10-07 05:20:00 +00:00 (Migrated from github.com)

Up

Up
stijnb1234 commented 2023-01-19 19:51:32 +00:00 (Migrated from github.com)

This issue is on task list for v3, closing this issue because of that.

This issue is on task list for v3, closing this issue because of that.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SBDevelopment/VehiclesPlus#78
No description provided.