Fuel goes to 0 when max speed is 0 #50

Closed
opened 2020-12-23 11:08:06 +00:00 by stijnb1234 · 2 comments
stijnb1234 commented 2020-12-23 11:08:06 +00:00 (Migrated from github.com)

Describe the bug
When we change the max speed to 0 with the API, there is a chance your fuel also updates to 0. This is weird behavior and shouldn't happen.

To Reproduce

  1. Update max speed to zero, because something happened
  2. There is a chance your fuel tank gets emptied

Expected behavior
Your fuel tank value should stay the same.

Screenshots or Video Recordings

Server and Plugin Information

  • VehiclesPlus Version: 2.1.0-dev5
  • Pro or Lite? Pro
  • Server Platform and Version [eg: PaperSpigot 1.16.1 #135]: PaperSpigot 1.16.4 #335
  • Operating System (if applicable): Ubuntu 18.04 [Linux based]

Additional context

**Describe the bug** When we change the max speed to 0 with the API, there is a chance your fuel also updates to 0. This is weird behavior and shouldn't happen. **To Reproduce** 1. Update max speed to zero, because something happened 2. There is a chance your fuel tank gets emptied **Expected behavior** Your fuel tank value should stay the same. **Screenshots or Video Recordings** - **Server and Plugin Information** - VehiclesPlus Version: 2.1.0-dev5 - Pro or Lite? Pro - Server Platform and Version [eg: **PaperSpigot** 1.16.1 #135]: PaperSpigot 1.16.4 #335 - Operating System (if applicable): Ubuntu 18.04 [Linux based] **Additional context** -
stale[bot] commented 2021-06-04 17:33:48 +00:00 (Migrated from github.com)

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.
stijnb1234 commented 2021-06-04 17:34:41 +00:00 (Migrated from github.com)

Since this can only be achieved with the API, it will not be worked in. In the recode I am going to see if this can be protected against. The best thing to do is to have the current and max speed simultaneously matter to 0.

Since this can only be achieved with the API, it will not be worked in. In the recode I am going to see if this can be protected against. The best thing to do is to have the current and max speed simultaneously matter to 0.
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SBDevelopment/VehiclesPlus#50
No description provided.