SBDevelopment/V10Lift
3
0
Fork 0
Code Issues 11 Pull requests Releases Wiki Activity Actions

[FEATURE] LoggerFactory WARN #50

New issue
Closed
opened 2020-07-20 19:05:13 +00:00 by SlimeDog · 4 comments
SlimeDog commented 2020-07-20 19:05:13 +00:00 (Migrated from github.com)
Copy link

Is your feature request related to a problem? Please describe.
On server start

[11:56:21] [Server thread/WARN]: [V10Lift] Loaded class org.slf4j.LoggerFactory from PureTickets v3.0.0 which is not a depend, softdepend or loadbefore of this plugin.
[11:56:21] [Server thread/WARN]: [Server thread] INFO nl.SBDeveloper.V10Lift.utils.hikari.HikariDataSource - V10Lift - Starting...
[11:56:21] [Server thread/WARN]: [Server thread] INFO nl.SBDeveloper.V10Lift.utils.hikari.HikariDataSource - V10Lift - Start completed.

Describe the solution you'd like
Please shade the LoggerFactory, rather than relying on PureTickets.
If possible, change the subsequent (hikari) WARN messages to INFO.

**Is your feature request related to a problem? Please describe.** On server start ``` [11:56:21] [Server thread/WARN]: [V10Lift] Loaded class org.slf4j.LoggerFactory from PureTickets v3.0.0 which is not a depend, softdepend or loadbefore of this plugin. [11:56:21] [Server thread/WARN]: [Server thread] INFO nl.SBDeveloper.V10Lift.utils.hikari.HikariDataSource - V10Lift - Starting... [11:56:21] [Server thread/WARN]: [Server thread] INFO nl.SBDeveloper.V10Lift.utils.hikari.HikariDataSource - V10Lift - Start completed. ``` **Describe the solution you'd like** Please shade the LoggerFactory, rather than relying on PureTickets. If possible, change the subsequent (hikari) WARN messages to INFO.
stijnb1234 commented 2020-07-20 19:14:16 +00:00 (Migrated from github.com)
Copy link

Will shade hikariCP into the jar. This should fix the problem.

Will also look into the messages. But they are from hikariCP.

Will shade hikariCP into the jar. This should fix the problem. Will also look into the messages. But they are from hikariCP.
SlimeDog commented 2020-07-20 19:16:49 +00:00 (Migrated from github.com)
Copy link

Will also look into the messages. But they are from hikariCP.

I imagine they are. But hopefully there is an option in the API to turn them off or modify the status to INFO.

> Will also look into the messages. But they are from hikariCP. I imagine they are. But hopefully there is an option in the API to turn them off or modify the status to INFO.
SlimeDog commented 2020-07-27 01:42:14 +00:00 (Migrated from github.com)
Copy link

More on shutdown

[18:40:10] [Server thread/WARN]: [Server thread] INFO nl.SBDeveloper.V10Lift.utils.hikari.HikariDataSource - V10Lift - Shutdown initiated...
[18:40:10] [Server thread/WARN]: [Server thread] INFO nl.SBDeveloper.V10Lift.utils.hikari.HikariDataSource - V10Lift - Shutdown completed.
[18:40:10] [Server thread/WARN]: [Server thread] INFO co.uk.magmo.puretickets.lib.hikari.HikariDataSource - DB - Shutdown initiated...
[18:40:10] [Server thread/WARN]: [Server thread] INFO co.uk.magmo.puretickets.lib.hikari.HikariDataSource - DB - Shutdown completed
More on shutdown ``` [18:40:10] [Server thread/WARN]: [Server thread] INFO nl.SBDeveloper.V10Lift.utils.hikari.HikariDataSource - V10Lift - Shutdown initiated... [18:40:10] [Server thread/WARN]: [Server thread] INFO nl.SBDeveloper.V10Lift.utils.hikari.HikariDataSource - V10Lift - Shutdown completed. [18:40:10] [Server thread/WARN]: [Server thread] INFO co.uk.magmo.puretickets.lib.hikari.HikariDataSource - DB - Shutdown initiated... [18:40:10] [Server thread/WARN]: [Server thread] INFO co.uk.magmo.puretickets.lib.hikari.HikariDataSource - DB - Shutdown completed ```
stijnb1234 commented 2020-07-27 06:05:49 +00:00 (Migrated from github.com)
Copy link

As you can see with other Plugins, it's not possible to easily change that text. I shaded hikari into my jar and closed this issue.

As you can see with other Plugins, it's not possible to easily change that text. I shaded hikari into my jar and closed this issue.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feature/api-overhaul
No results found.
Labels
Clear labels   
bug

Something isn't working

  
can reproduce

The issue can be reproduced

  
can't reproduce

The issue can't be reproduced

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
incompatibility

This issue is caused by a conflict with another plugin

  
invalid

This doesn't seem right

  
needs confirmation

This issue needs confirmation

  
needs more information

More information is required from the reporter

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
can reproduce
can't reproduce
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
incompatibility
invalid
needs confirmation
needs more information
question
wontfix
Milestone
Clear milestone
No items
No milestone
0.6.2
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SBDevelopment/V10Lift#50
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?