[FEATURE] Use known info for Start/stop commands

SlimeDog commented

2020-02-22 15:28:07 +00:00

(Migrated from github.com)

Describe the bug
Start and stop should use context to determine appropriate actions:

If the player is in an elevator, the elevator name is known from the location.
If the player is in an elevator, the target floor is known from the sign.
In this case, the only command required should be

v10lift start
v10lift stop

Spigot version (use /version):
1.15.2

Plugin version (use /v10lift info), NOT LATEST!!!
0.5.2

**Describe the bug** Start and stop should use context to determine appropriate actions: - If the player is in an elevator, the elevator name is known from the location. - If the player is in an elevator, the target floor is known from the sign. In this case, the only command required should be > v10lift start > v10lift stop **Spigot version (use /version):** 1.15.2 **Plugin version (use /v10lift info), NOT LATEST!!!** 0.5.2

stijnb1234 commented

2020-02-22 15:30:59 +00:00

(Migrated from github.com)

If the player is in an elevator, the elevator name is known from the location.

This is not possible, because it is not possible to find the elevator name from the location, because you only add the cab floor, and not the whole cab.

> If the player is in an elevator, the elevator name is known from the location. This is not possible, because it is not possible to find the elevator name from the location, because you only add the cab floor, and not the whole cab.

SlimeDog commented

2020-02-22 15:32:04 +00:00

(Migrated from github.com)

I am standing somewhere above the cab floor. :)

stijnb1234 commented

2020-02-22 15:33:09 +00:00

(Migrated from github.com)

Yes, I know. But it's not safe to assume that you are always standing on the cab floor.

What I can do though, is check if the block below is from the lift, and if not so, it will return an error.

Yes, I know. But it's not safe to assume that you are always standing on the cab floor. What I can do though, is check if the block below is from the lift, and if not so, it will return an error.

SlimeDog commented

2020-02-22 15:34:17 +00:00

(Migrated from github.com)

If a button is part of the cab, and within one block of the sign, all the necessary data are known. The button-click could execute the same as left-click on the adjacent sign.

SlimeDog commented

2020-02-23 00:16:22 +00:00

(Migrated from github.com)

Looks good. I will test when released.

stijnb1234 commented

2020-02-23 09:55:13 +00:00

(Migrated from github.com)

The snapshot is now available: v0.5.3-SNAPSHOT

The snapshot is now available: [v0.5.3-SNAPSHOT](https://github.com/stijnb1234/V10Lift2/releases/tag/v0.5.3-SNAPSHOT)

SlimeDog commented

2020-02-24 07:44:36 +00:00

(Migrated from github.com)

Works great! Thank you. We now have CommandSigns buttons adjacent to the floor-selection sign. Thanks to the start command, the elevator works even in Adventure mode.

[FEATURE] Use known info for Start/stop commands #29